Re: Remove pg_am.amindexnulls?

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: Remove pg_am.amindexnulls?
Date: 2011-01-08 12:15:52
Message-ID: m2y66vr3pj.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
> Now that GIN can index null items, its amindexnulls flag in pg_am really
> ought to be set true. However, looking at the usage of that column,
> I wonder whether we shouldn't just delete it instead. The only present
> usage is a rather convoluted test in CLUSTER to see if the index is
> safely clusterable --- and AFAICS that test has been obsoleted anyhow
> by the later addition of pg_am.amclusterable. Anyone against
> simplifying matters by getting rid of pg_am.amindexnulls?

There has been multiple attempts at implementing bitmap indexes in the
"recent" past, any impact between that efforts and your change? That's
all I can think about and I don't even know how much it's related…

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2011-01-08 12:17:51 Re: We need to log aborted autovacuums
Previous Message Dimitri Fontaine 2011-01-08 12:14:05 Re: obj_unique_identifier(oid)