From: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
---|---|
To: | Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> |
Cc: | Robert Haas <robertmhaas(at)gmail(dot)com>, Simon Riggs <simon(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Greg Smith <greg(at)2ndquadrant(dot)com>, Bruce Momjian <bruce(at)momjian(dot)us> |
Subject: | Re: Command Triggers |
Date: | 2012-02-17 17:06:05 |
Message-ID: | m2ipj5jsoy.fsf@2ndQuadrant.fr |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr> writes:
>>>> I think it would be better to bail on trying to use CREATE TRIGGER and
>>>> DROP TRIGGER as a basis for this functionality, and instead create
>>>> completely new toplevel statements CREATE COMMAND TRIGGER and DROP
>>>> COMMAND TRIGGER. Then, you could decide that all command triggers
>>>> live in the same namespace, and therefore to get rid of the command
>>>> trigger called bob you can just say "DROP COMMAND TRIGGER bob",
>>>> without having to specify the type of command it applies to. It's
>
> I guess that's a point to change the grammar the way you're hinting:
>
> CREATE COMMAND TRIGGER
> DROP COMMAND TRIGGER
> ALTER COMMAND TRIGGER
>
> That also needs each their own reference page. It will be easier on the
> users I guess. Will work on that.
FWIW I've pushed such a change to my github repository, I'm not spamming
the list with v10 already though, unless someone wants to see it.
https://github.com/dimitri/postgres/commit/82996b45aae10f12818f1e3097ba805fff22a97b
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2012-02-17 17:07:44 | Re: Command Triggers |
Previous Message | Andrew Dunstan | 2012-02-17 16:58:31 | Re: Triggers with DO functionality |