Re: ALTER OBJECT any_name SET SCHEMA name

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Dimitri Fontaine <dimitri(at)2ndquadrant(dot)fr>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ALTER OBJECT any_name SET SCHEMA name
Date: 2010-11-23 08:18:56
Message-ID: m27hg4ihan.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Robert Haas <robertmhaas(at)gmail(dot)com> writes:
> Especially because you also posted some revs of the ALTER EXTENSION ..
> SET SCHEMA patch on this thread....

Yes, I tried to answer where questions have been raised, and that's not
helping so much at review time. That's why I take the time to update the
commit fest application each time I send a new patch version.

>> Do you still want me to prepare another patch for adding in the tests
>> the "set schema" variants that already existed but are not yet covered?
>> Which are the one you did spot, btw?
>
> [rhaas pgsql]$ git grep 'SET SCHEMA' src/test/regress/
> [rhaas pgsql]$

The existing 'set schema' tests are in lower case, so I just did it the
same, try with git grep -i maybe :)

grep -c 'set schema' ../postgresql-extension-patches/set_schema.v8.patch
28

> Please do. Tab completion support should really be included in the
> patch - adding it as a separate patch is better than not having it, of
> course.

Ok, will learn about this part of psql soon'ish, hopefully by today,
given a reasonable amount of other "distractions".

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2010-11-23 08:24:46 Re: Extensions, this time with a patch
Previous Message 高增琦 2010-11-23 08:13:50 Re: visibility map