Re: Extensions and custom_variable_classes

From: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Dimitri Fontaine <dimitri(at)2ndQuadrant(dot)fr>, Robert Haas <robertmhaas(at)gmail(dot)com>, Itagaki Takahiro <itagaki(dot)takahiro(at)gmail(dot)com>, PostgreSQL-Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Extensions and custom_variable_classes
Date: 2010-12-19 18:35:08
Message-ID: m239pta9wj.fsf@2ndQuadrant.fr
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> writes:
> Just to point out one concrete problem: the postmaster reads
> postgresql.conf too, so it would have to do this as well in order to
> parse postgresql.conf correctly.

Well, if I parse you correctly, in my patch, it does. There's another
GUC array where to store invalid placeholders so that we can revisit
later. That even allows custom_variable_classes not to be parsed first
in the list, even if that's not put into use in the patch.

> Please remove it. If you think of a non-broken way to do this later,
> we can revisit the problem then.

Sure. I'm curious about understanding how it's broken and if there's
any will at all to have something better (and what better would be), but
it's now obvious that it's not going to help the extension patch.

Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dimitri Fontaine 2010-12-19 18:39:23 Re: Extensions and custom_variable_classes
Previous Message Jim Nasby 2010-12-19 18:13:49 Re: keeping a timestamp of the last stats reset (for a db, table and function)