Re: [HACKERS] Did the inet type get backed out?

From: darcy(at)druid(dot)net (D'Arcy J(dot)M(dot) Cain)
To: tih(at)nhh(dot)no (Tom Ivar Helbekkmo)
Cc: maillist(at)candle(dot)pha(dot)pa(dot)us (Bruce Momjian), pgsql-hackers(at)postgreSQL(dot)org
Subject: Re: [HACKERS] Did the inet type get backed out?
Date: 1998-10-16 12:11:53
Message-ID: m0zU8jZ-0000emC@druid.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Thus spake Tom Ivar Helbekkmo
> darcy(at)druid(dot)net (D'Arcy J.M. Cain) writes:
> > But it worked before. In fact it still works on another system with
> > an earlier compile.
>
> "Works" for me, using a cvs update from yesterday morning (the morning
> after the BETA 2 freeze), modulo the fact that someone committed
> changes to #ifdef out ("#ifdef BAD") all the calls to the actual inet
> parser routines, effectively causing all data to be rejected. Since

That's odd. I know that Bruce #ifdef'd out the core of the _new_
functions I sent in but I didn't realize that he took the existing
ones out too.

> we had an implementation that actually worked, and the changes that we
> wanted to make were compatible with currently stored data, it would
> have been smarter to leave it working until the changes were ready to
> be committed. It's better to be able to keep testing something that
> doesn't have all the wanted functionality than to disable it until an
> unknown time in the future! :-)

Yes, I agree. Bruce, can we put the inet_in and inet_out functions
back the way they were?

However, I have put all the code back in locally for testing so that
isn't why mine isn't working. I'll try with today's sup.

--
D'Arcy J.M. Cain <darcy(at){druid|vex}.net> | Democracy is three wolves
http://www.druid.net/darcy/ | and a sheep voting on
+1 416 424 2871 (DoD#0082) (eNTP) | what's for dinner.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jan Wieck 1998-10-16 13:27:48 Bug in keywords.c
Previous Message Edmund Mergl 1998-10-16 10:40:55 Re: [HACKERS] perl interface bug?