Re: Adding NetBSD and OpenBSD to Postgres CI

Hi,

On 2024-11-07 16:05:43 +0100, Peter Eisentraut wrote:
> On 07.11.24 14:40, Nazir Bilal Yavuz wrote:
> > > I noticed that neither the existing FreeBSD task nor the new OpenBSD one
> > > find the bsd_auth.h header. I thought this would be good to get more
> > > testing of that code. Do you know why that is?
> >
> > The 'bsd_auth.h' file does not exist in FreeBSD.
> >
> > For the OpenBSD, it exists but its compilation fails with:
> > '''
> > /usr/include/bsd_auth.h:93:1: error: unknown type name 'quad_t'
> > /usr/include/bsd_auth.h:94:1: error: unknown type name 'quad_t
> > '''
> >
> > These 'quad_t' types are defined in the 'sys/types.h' file.
>
> Makes sense. The synopsis in https://man.openbsd.org/authenticate.3 is:
>
> #include <sys/types.h>
> #include <login_cap.h>
> #include <bsd_auth.h>

It doesn't really make sense to me - it seems like a bug if system headers
aren't standalone. And the synopsys including a header doesn't seem to
obviously indicate that every user has to do so.

But anyway, we probably just have to deal with the world as it, rather than
how it should be :(

Greetings,

Andres Freund