warnings patch submission

From: Richard PALO <richard(dot)palo(at)baou(dot)fr>
To: pgadmin-hackers(at)postgresql(dot)org
Subject: warnings patch submission
Date: 2013-07-19 13:58:01
Message-ID: ksbgl2$kmf$1@ger.gmane.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

The following patch should get over the (in this case cosmetic) warning:
> ./gqb/gqbView.cpp: In member function 'void gqbView::onMotion(wxMouseEvent&)':
> ./gqb/gqbView.cpp:344:16: warning: converting 'false' to pointer type 'gqbObject*' [-Wconversion-null]
> anySelected = false;
> ^

diff --git a/pgadmin/gqb/gqbView.cpp b/pgadmin/gqb/gqbView.cpp
index 3afe4c8..9d5bab6 100644
--- a/pgadmin/gqb/gqbView.cpp
+++ b/pgadmin/gqb/gqbView.cpp
@@ -341,7 +341,7 @@ void gqbView::onMotion(wxMouseEvent &event)
}
else
{
- anySelected = false;
+ anySelected = NULL;
mode = pt_normal;
}

==================================================================
On the other hand, the maintainer may wish to take a look at the
following warnings in pgadmin/ogl/drawn.cpp:

> ./ogl/drawn.cpp: In member function 'virtual void wxOpSetGDI::Do(wxDC&, double, double)':
> ./ogl/drawn.cpp:423:53: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> if (m_image->m_outlineColours.Member((wxObject *)m_gdiIndex))
> ^
> ./ogl/drawn.cpp:444:53: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> if (m_image->m_outlineColours.Member((wxObject *)m_gdiIndex))
> ^
> ./ogl/drawn.cpp:454:55: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> else if (m_image->m_fillColours.Member((wxObject *)m_gdiIndex))
> ^
> ./ogl/drawn.cpp: In member function 'virtual void wxPseudoMetaFile::SetPen(wxPen*, bool)':
> ./ogl/drawn.cpp:2443:46: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> m_outlineColours.Append((wxObject *) (n - 1));
> ^
> ./ogl/drawn.cpp: In member function 'virtual void wxPseudoMetaFile::SetBrush(wxBrush*, bool)':
> ./ogl/drawn.cpp:2458:43: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
> m_fillColours.Append((wxObject *) (n - 1));
> ^
^

Responses

Browse pgadmin-hackers by date

  From Date Subject
Next Message Dave Page 2013-07-19 15:47:33 pgAdmin III commit: Fix assignment.
Previous Message Dave Page 2013-07-19 13:08:22 pgAdmin III commit: Fix build for wx 2.9.5, along with an RPATH issue.