Re: ecpglib use PQconnectdbParams

From: Christian Ullrich <chris(at)chrullrich(dot)net>
To: pgsql-hackers(at)postgresql(dot)org
Subject: Re: ecpglib use PQconnectdbParams
Date: 2012-02-03 12:15:30
Message-ID: jggj53$4rk$1@dough.gmane.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

* Peter Eisentraut wrote:

> I noticed ecpglib still uses PQconnectdb() with a craftily assembled
> connection string. Here is a patch to use PQconnectdbParams() instead.

+ const char *conn_keywords[6];
+ const char *conn_values[6];

Shouldn't these be [7]? You can have up to 6 items, plus the terminator.

--
Christian Ullrich

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2012-02-03 12:52:34 Re: patch for parallel pg_dump
Previous Message Fujii Masao 2012-02-03 09:55:42 Re: Patch pg_is_in_backup()