From: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
---|---|
To: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
Cc: | Simon Riggs <simon(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [COMMITTERS] pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset() |
Date: | 2010-04-08 02:15:23 |
Message-ID: | g2p3f0b79eb1004071915ma05e32cgd73fa7ffcbaba8c3@mail.gmail.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers pgsql-hackers |
On Wed, Apr 7, 2010 at 7:23 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)enterprisedb(dot)com> wrote:
> This commit is a stop-gap solution until we figure out what exactly to
> do about that. Masao-san wrote a patch that included the TLI in the
> string returned by pg_last_xlog_receive/replay_location() (see
> http://archives.postgresql.org/message-id/3f0b79eb1003030603ibd0cbadjebb09fa4249304ba@mail.gmail.com
> and
> http://archives.postgresql.org/message-id/3f0b79eb1003300214r6cf98c46tc9be5d563ccf48db@mail.gmail.com)
> but it still wasn't clear it did the right thing in corner-cases where
> the TLI changes. Using GetRecoveryTargetTLI() for the tli returned by
> pg_last_receive_location() seems bogus, at least.
Why? The tli of the last WAL record received is always the
recovery target tli currently. So using GetRecoveryTargetTLI()
for pg_last_xlog_receive_location() seems OK for me.
Am I missing something?
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2010-04-08 06:54:40 | Re: [COMMITTERS] pgsql: Forbid using pg_xlogfile_name() and pg_xlogfile_name_offset() |
Previous Message | Robert Haas | 2010-04-08 01:39:37 | pgsql: Make smart shutdown work in combination with Hot |
From | Date | Subject | |
---|---|---|---|
Next Message | Dhiraj Lohiya | 2010-04-08 03:35:11 | Re: Enhancing phonetic search support for more languages - GSoC 2010 |
Previous Message | Robert Haas | 2010-04-08 01:46:47 | Re: Remaining Streaming Replication Open Items |