| From: | Dave Page <dpage(at)pgadmin(dot)org> |
|---|---|
| To: | Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com> |
| Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, pgadmin-hackers(at)postgresql(dot)org |
| Subject: | Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image |
| Date: | 2010-04-22 16:18:38 |
| Message-ID: | g2k937d27e11004220918g8bad1f7fh286bef9d059d08b3@mail.gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
On Thu, Apr 22, 2010 at 4:57 PM, Ashesh Vashi
<ashesh(dot)vashi(at)enterprisedb(dot)com> wrote:
> Yeah..
> It does require only in gtk.. (linux)
> "--enable-printarch --with-gnomeprint"...
> And, It requires "libgnomeprint" package to be installed on development
> machine...
That's a potential problem - we're at the mercy of the packagers on
most OS's and they may not have configured wxWidgets correctly for our
needs.
I think we need to make the printing feature conditional on whether
wxWidgets has been compiled appropriately, which probably needs a
configure test. If support for printing isn't there, then it needs to
build pgAdmin without those options.
Also - I noticed near the top of the patch that there were a few
strings that looked translatable which were wrapped in _T(). That
should be _() for translatable strings, or wxT() for non-translatable.
--
Dave Page
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ashesh Vashi | 2010-04-22 16:48:08 | Re: PATCH(WIP): Printing Support And Save GQB/Explain as an image |
| Previous Message | Dave Page | 2010-04-22 16:02:20 | Re: PATCH: Segment Fault when restoring a backup file from the schema node |