Re: Is it useful to record whether plans are generic or custom?

From: torikoshia <torikoshia(at)oss(dot)nttdata(dot)com>
To: Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com>
Cc: Atsushi Torikoshi <atorik(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, legrand legrand <legrand_legrand(at)hotmail(dot)com>, Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp>
Subject: Re: Is it useful to record whether plans are generic or custom?
Date: 2020-06-10 01:50:58
Message-ID: ffb35c235b5040d6da946ab0bdf06e3b@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-06-08 20:45, Masahiro Ikeda wrote:

> BTW, I found that the dependency between function's comments and
> the modified code is broken at latest patch. Before this is
> committed, please fix it.
>
> ```
> diff --git a/src/backend/commands/prepare.c
> b/src/backend/commands/prepare.c
> index 990782e77f..b63d3214df 100644
> --- a/src/backend/commands/prepare.c
> +++ b/src/backend/commands/prepare.c
> @@ -694,7 +694,8 @@ ExplainExecuteQuery(ExecuteStmt *execstmt,
> IntoClause *into, ExplainState *es,
>
> /*
> * This set returning function reads all the prepared statements and
> - * returns a set of (name, statement, prepare_time, param_types,
> from_sql).
> + * returns a set of (name, statement, prepare_time, param_types,
> from_sql,
> + * generic_plans, custom_plans, last_plan).
> */
> Datum
> pg_prepared_statement(PG_FUNCTION_ARGS)
> ```

Thanks for reviewing!

I've fixed it.

Regards,

--
Atsushi Torikoshi

Attachment Content-Type Size
0004-Expose-counters-of-plancache-to-pg_prepared_statement.patch text/x-diff 12.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2020-06-10 02:15:44 Re: Default setting for enable_hashagg_disk
Previous Message Melanie Plageman 2020-06-10 01:20:13 Re: Default setting for enable_hashagg_disk