| From: | Masahiro Ikeda <ikedamsh(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | LogicalChanges* and LogicalSubxact* wait events are never reported |
| Date: | 2021-10-20 05:12:20 |
| Message-ID: | ff077840-3ab2-04dd-bbe4-4f5dfd2ad481@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
When I read the documents and source code of wait evens,
I found that the following wait events are never reported.
* LogicalChangesRead: Waiting for a read from a logical changes file.
* LogicalChangesWrite: Waiting for a write to a logical changes file.
* LogicalSubxactRead: Waiting for a read from a logical subxact file.
* LogicalSubxactWrite: Waiting for a write to a logical subxact file.
The wait events are introduced in the following patch.
Add support for streaming to built-in logical replication.
Amit Kapila on 2020/9/3 11:24:07
464824323e57dc4b397e8b05854d779908b55304
I read the above discussion and found the wait events were reported at first.
But they seemed to be removed because they are not necessary because
BufFileWrite/BufFileRead are enough([1]).
If my understanding is right, it's better to remove them since they make
users confused. Please see the attached patch. I confirmed that to make
check-world passes all tests.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
| Attachment | Content-Type | Size |
|---|---|---|
| v1_remove_unreported_wait_events.patch | text/x-patch | 2.3 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2021-10-20 05:13:15 | Re: pg_receivewal starting position |
| Previous Message | Dilip Kumar | 2021-10-20 04:55:05 | Re: pgsql: Document XLOG_INCLUDE_XID a little better |