| From: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com> |
|---|---|
| To: | Thomas Munro <thomas(dot)munro(at)enterprisedb(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Cc: | Andres Freund <andres(at)anarazel(dot)de>, Andrew Gierth <andrew(at)tao11(dot)riddles(dot)org(dot)uk> |
| Subject: | Re: TupleDescCopy doesn't clear atthasdef, attnotnull, attidentity |
| Date: | 2017-12-27 15:03:59 |
| Message-ID: | fee41371-d433-9352-07b7-017f136c5901@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 11/29/2017 08:58 AM, Thomas Munro wrote:
> Hi hackers,
>
> Andrew Gierth complained off-list that TupleDescCopy() doesn't clear
> atthasdef. Yeah, that's an oversight. The function is new in commit
> cc5f81366c36 and was written by me to support "flat" (pointer-free)
> tuple descriptors for use in DSM. Following the example of
> CreateTupleDescCopy() I think it should also clear attnotnull and
> attidentity. Please see attached.
This trivial patch is a clear oversight in the original patch. Thank
you to Andrew for some explanation off-list to help me understand tuple
descriptors better.
Ready for committer.
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Dmitry Dolgov | 2017-12-27 15:16:36 | Re: [HACKERS] [PATCH] Generic type subscripting |
| Previous Message | Yugo Nagata | 2017-12-27 14:31:54 | Re: [HACKERS] [PATCH] Lockable views |