pg_upgrade check fails on Solaris 10

From: Marina Polyakova <m(dot)polyakova(at)postgrespro(dot)ru>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Victor Wagner <v(dot)wagner(at)postgrespro(dot)ru>
Subject: pg_upgrade check fails on Solaris 10
Date: 2019-09-17 16:07:31
Message-ID: feba89f89e8925b3535cb7d72b9e05e1@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello, hackers!

We got an error for pg_upgrade check on the branch REL_11_STABLE (commit
40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the
argument to the sed command is not enclosed in quotation marks (see
[1]):

$ gmake -C src/bin/pg_upgrade/ check
<...>
MAKE=gmake
bindir="/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/inst/bin"
libdir="/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/inst/lib"
EXTRA_REGRESS_OPTS="" /bin/sh test.sh --install
test.sh: MSYS/MINGW/: not found
gmake: *** [check] Error 1
gmake: Leaving directory
`/home/buildfarm/mpolyakova/postgrespro_REL_11_STABLE/src/bin/pg_upgrade'
$ sed: command garbled: s/

Attached diff.patch fixes the problem.

About the system: SunOS, Release 5.10, KernelID Generic_141444-09.
About the used shell: according to the manual, it comes from the package
SUNWcsu.

Thanks to Victor Wagner for his help to investigate this issue.

[1] $ man sh
<...>
Quoting
The following characters have a special meaning to the shell and cause
termination of a word unless quoted:
; & ( ) | ^ < > newline space tab

--
Marina Polyakova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company

Attachment Content-Type Size
diff.patch text/x-diff 520 bytes

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Erik Rijkers 2019-09-17 16:09:01 Re: Define jsonpath functions as stable
Previous Message Robert Haas 2019-09-17 15:54:45 Re: subscriptionCheck failures on nightjar