Re: Example 43.6. A PL/pgSQL Trigger Function for Maintaining a Summary Table

From: Maxim Yablokov <m(dot)yablokov(at)postgrespro(dot)ru>
To: Daniel Gustafsson <daniel(at)yesql(dot)se>
Cc: pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: Example 43.6. A PL/pgSQL Trigger Function for Maintaining a Summary Table
Date: 2023-10-26 10:31:07
Message-ID: fe405123-9cae-4f16-81c0-4e73bec93b81@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

I believe that the attached patch should fix this problem. Please have a
look.

26.10.2023 12:29, Daniel Gustafsson пишет:
>> On 26 Oct 2023, at 09:33, Maxim Yablokov<m(dot)yablokov(at)postgrespro(dot)ru> wrote:
>> Example 43.6 on the pagehttps://www.postgresql.org/docs/16/plpgsql-trigger.html has two tables called main. But it seems that the table time_dimension is not used any further, it's a bit strange for one of main tables of the example. Am I missing something, or should this example be extended (or reduced)?
> Interesting catch, time_dimension has been unused since introduced with commit
> a294726bc1d (in 2005), and the archives doesn't provide any further insights.
> While I don't have access to the book referred to for the example, we don't
> expect our readers to either so it seems to me that we could remove it from the
> example to avoid risk of confusion. Would you like to propose a patch for this?
>
> --
> Daniel Gustafsson
>
--
Best regards,
Maxim Yablokov
Technical writer-translator
Postgres Professional <https://postgrespro.com/>

Attachment Content-Type Size
plpgsql-trigger.patch text/x-patch 888 bytes

In response to

Responses

Browse pgsql-docs by date

  From Date Subject
Next Message PG Doc comments form 2023-10-26 11:46:55 pg_isready --dbname option is broken. So it should not be in the manual
Previous Message Maxim Yablokov 2023-10-26 09:36:02 Re: Example 43.6. A PL/pgSQL Trigger Function for Maintaining a Summary Table