| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Melanie Plageman <melanieplageman(at)gmail(dot)com> |
| Cc: | Peter Geoghegan <pg(at)bowt(dot)ie>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Subject: | Re: Show various offset arrays for heap WAL records |
| Date: | 2023-10-02 09:19:29 |
| Message-ID: | fe32d2a0-0998-d866-d6ee-2aed70b9be00@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/09/2023 23:02, Melanie Plageman wrote:
> I might phrase the last bit as "neither the description functions nor
> the output format should be considered part of a stable API"
>
> +Guidelines for rmgrdesc output format
> +=====================================
>
> I noticed you used === for both headings and wondered if it was
> intentional. Other READMEs I looked at in src/backend/access tend to
> have a single heading underlined with ==== and then subsequent
> headings are underlined with -----. I could see an argument either way
> here, but I just thought I would bring it up in case it was not a
> conscious choice.
>
> Otherwise, LGTM.
Made these changes and committed. Thank you!
--
Heikki Linnakangas
Neon (https://neon.tech)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Drouvot, Bertrand | 2023-10-02 09:35:45 | Replace (stat(<file>))[7] in TAP tests with -s |
| Previous Message | Pavel Borisov | 2023-10-02 09:15:09 | Re: [PATCH] Clarify the behavior of the system when approaching XID wraparound |