| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | David Zhang <david(dot)zhang(at)highgo(dot)ca>, Pgsql Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: wrong comment in libpq.h |
| Date: | 2024-05-03 11:48:20 |
| Message-ID: | fd92aec8-56c2-4562-a673-d955271b5f30@eisentraut.org |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03.05.24 00:37, David Zhang wrote:
> Hi Hackers,
>
> There is a comment like below in src/include/libpq/libpq.h,
>
> /*
> * prototypes for functions in be-secure.c
> */
> extern PGDLLIMPORT char *ssl_library;
> extern PGDLLIMPORT char *ssl_cert_file;
>
> ...
>
> However, 'ssl_library', 'ssl_cert_file' and the rest are global
> parameter settings, not functions. To address this confusion, it would
> be better to move all global configuration settings to the proper
> section, such as /* GUCs */, to maintain consistency.
Maybe it's easier if we just replaced
prototypes for functions in xxx.c
with
declarations for xxx.c
throughout src/include/libpq/libpq.h.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2024-05-03 11:53:28 | Re: wrong comment in libpq.h |
| Previous Message | Richard Guo | 2024-05-03 11:47:45 | Re: A problem about partitionwise join |