| From: | Ryoga Yoshida <bt23yoshidar(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Aleksander Alekseev <aleksander(at)timescale(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
| Subject: | Re: Bug fix for psql's meta-command \ev |
| Date: | 2023-09-19 06:29:11 |
| Message-ID: | fd0bb41626615142bdd6cffe1ddcba52@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-09-19 12:53, Michael Paquier wrote:
> Adding a comment looks important to me once we consider the edit as a
> path that can fail and the edited query is only executed then reset
> when we have PSQL_CMD_NEWEDIT as status. I would suggest the patch
> attached instead, taking care of the error case of this thread and the
> ones I've spotted.
Thank you everyone for the reviews. I fixed the patch for the error and
also added a comment
. You can see attached file.
Ryoga Yoshida
| Attachment | Content-Type | Size |
|---|---|---|
| bug_fix_for_ev_command_2.patch | text/x-diff | 531 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2023-09-19 07:01:56 | Re: information_schema and not-null constraints |
| Previous Message | Michael Paquier | 2023-09-19 06:19:29 | Re: pg_upgrade and logical replication |