Re: pg_upgrade fails with non-standard ACL

On 21.01.2021 07:07, Noah Misch wrote:
>> On Thu, Jun 11, 2020 at 07:58:43PM +0300, Anastasia Lubennikova wrote:
>> Thank you for the review.
>> New version of the patch is attached, though I haven't tested it properly
>> yet. I am planning to do in a couple of days.
> Once that testing completes, please change the commitfest entry status to
> Ready for Committer.
>
New version is attached along with a test script.

To use it, you can simply run pg_upgrade_ACL_test.sh script in a
directory that contains postrges git repository. See comments in the file.

The test includes patch to rename several system objects.

Renamed objects are the following:
- table pg_subscription -> pg_sub
- columns pg_subscription.subenabled -> subactive,
- view pg_stat_subscription -> pg_stat_sub
pg_stat_subscription.latest_end_lsn -> latest_end_location
- function pg_stat_get_subscription -> pg_stat_get_sub
- language sql -> pgsql

Compared to v11, I fixed a couple of minor issues and removed language
support.
It seems unlikely, that we will ever change language signature, which
consist of language name only.

--
Anastasia Lubennikova
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company