From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
---|---|
To: | Stephen Frost <sfrost(at)snowman(dot)net> |
Cc: | David Steele <david(at)pgmasters(dot)net>, Michael Paquier <michael(at)paquier(dot)xyz>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: perlcritic and perltidy |
Date: | 2018-05-08 17:31:22 |
Message-ID: | fb4badd4-6ac5-9ce9-bc0f-af97c5a5363f@2ndQuadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 05/08/2018 01:18 PM, Stephen Frost wrote:
> Andrew,
>
> * Andrew Dunstan (andrew(dot)dunstan(at)2ndquadrant(dot)com) wrote:
>> On 05/08/2018 12:51 PM, Stephen Frost wrote:
>>> * Andrew Dunstan (andrew(dot)dunstan(at)2ndquadrant(dot)com) wrote:
>>> There's not much point adding the ',' unless you're also putting the
>>> ');' on the next line, is there..?
>> No, not really.
>>
>>> Or is that going to be handled in a follow-up patch?
>> No, the current proposal is to keep the vertical tightness settings for
>> parentheses, which is precisely this set of cases, because otherwise
>> there are some ugly code efects (see Peter's email upthread)
>>
>> So I think we're all in agreement to fortget this trailing comma thing.
> Well, agreed, for parentheses, but for curly-brace blocks, it'd be nice to
> have them since those will end up on their own line, right?
>
Yes, but there isn't a perlcritic policy I can find that detects them
reliably. If you know of one we can revisit it. Specifically, the one
from the Pulp collection called RequireTrailingCommaAtNewline didn't
work very well when I tried it.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2018-05-08 17:41:51 | Re: perlcritic and perltidy |
Previous Message | Stephen Frost | 2018-05-08 17:18:58 | Re: perlcritic and perltidy |