Re: Let's get rid of serial_schedule

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Let's get rid of serial_schedule
Date: 2021-05-11 19:12:46
Message-ID: fb34bbd4-2155-0944-e3a2-ae8d0e0dd09d@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 11/05/2021 21:58, Tom Lane wrote:
> We've several times discussed doing $SUBJECT by replacing the
> makefile's use of serial_schedule with calling parallel_schedule
> with --max-connections=1. This'd remove the need to maintain
> two lists of regression test scripts.
>
> I got annoyed again just now about how people seem unable to
> keep the two lists in the same order, so here is a patch to
> get rid of serial_schedule in that way.

+1

> + # for backwards compatibility, interpret "serial" as parallel tests

This comment isn't great, IMHO. How about:

# for backwards comopatibility, "serial" runs the tests in
# parallel_schedule one by one.

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Joe Conway 2021-05-11 19:18:29 Re: PG 14 release notes, first draft
Previous Message Daniel Gustafsson 2021-05-11 19:11:32 Re: Let's get rid of serial_schedule