Re: [patch] [doc] Clarify that signal functions have no feedback

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>
Cc: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: [patch] [doc] Clarify that signal functions have no feedback
Date: 2020-11-18 08:32:03
Message-ID: fac05ca4-96a4-706d-6a84-6e903fe58dd8@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 17/11/2020 21:50, David G. Johnston wrote:
> On Tue, Nov 17, 2020 at 6:13 AM Heikki Linnakangas <hlinnaka(at)iki(dot)fi
> <mailto:hlinnaka(at)iki(dot)fi>> wrote:
> You can use the <link
> linkend="view-pg-file-settings">pg_file_settings</link> and <link
> linkend="view-pg-hba-file-rules">pg_hba_file_rules</link> views to
> check
> the configuration files for possible errors, before reloading.
>
>
> I agree with adding "why" you want to check those links, and added a bit
> about why doing so before reloading works, but the phrasing using "You"
> seems out-of-place in this region of the documentation.

There are plenty of "you"s in the docs. Matter of taste, for sure, but
I'd prefer more active voice. Me being stubborn, I pushed this using my
wording. :-)

Thanks!

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2020-11-18 08:38:21 Re: [HACKERS] logical decoding of two-phase transactions
Previous Message Daniel Gustafsson 2020-11-18 08:25:44 Re: Move OpenSSL random under USE_OPENSSL_RANDOM