Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Andres Freund <andres(at)anarazel(dot)de>, Stephen Frost <sfrost(at)snowman(dot)net>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)berkus(dot)org>, Magnus Hagander <magnus(at)hagander(dot)net>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Daniel Verite <daniel(at)manitou-mail(dot)org>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Fujii Masao <masao(dot)fujii(at)gmail(dot)com>, Vladimir Rusinov <vrusinov(at)google(dot)com>, David Steele <david(at)pgmasters(dot)net>, Cynthia Shang <cynthia(dot)shang(at)crunchydata(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal
Date: 2017-02-10 01:03:51
Message-ID: fa4d8917-28cc-f0bc-e56f-c07011d2be89@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/9/17 6:37 PM, Andres Freund wrote:
>>> Anybody who still wants tsearch2 can go get it from an old version, or
>>> somebody can maintain a fork on github.
>> Works for me.
> +1

+1

>> I'd love to nuke pg_shadow and all the other
>> not-really-maintained backwards-compat things from when roles were
>> added too.
> Not sure if it's worth the work to rip out and such, but I'm mildly
> supportive of this one too. Depends a bit on what all the other things
> are ;)

The problem with pg_shadow is unless you specifically looked at it in
the docs after 8.1, you had no idea it was deprecated. I don't really
think of it as deprecated.

As someone mentioned, forcing a user to install an extension makes the
deprecation visible. Another option would be to have the backend spit
out a WARNING the first time you access anything that's deprecated. Both
of those are pertinent reminders to people that they need to change
their tools.
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Experts in Analytics, Data Architecture and PostgreSQL
Data in Trouble? Get it in Treble! http://BlueTreble.com
855-TREBLE2 (855-873-2532)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2017-02-10 01:15:25 Re: amcheck (B-Tree integrity checking tool)
Previous Message Stephen Frost 2017-02-10 01:02:54 Re: [PATCH] Rename pg_switch_xlog to pg_switch_wal