Re: BitmapHeapScan streaming read user and prelim refactoring

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Andres Freund <andres(at)anarazel(dot)de>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>
Subject: Re: BitmapHeapScan streaming read user and prelim refactoring
Date: 2024-06-18 22:02:56
Message-ID: fa2eaaec-4045-4656-9f2a-03a6841c42c8@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

I went through v22 to remind myself of what the patches do and do some
basic review - I have some simple questions / comments for now, nothing
major. I've kept the comments in separate 'review' patches, it does not
seem worth copying here.

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Attachment Content-Type Size
v22b-0001-table_scan_bitmap_next_block-counts-lossy-and-e.patch text/x-patch 5.1 KB
v22b-0002-review.patch text/x-patch 785 bytes
v22b-0003-Remove-table_scan_bitmap_next_tuple-parameter-t.patch text/x-patch 4.0 KB
v22b-0004-Make-table_scan_bitmap_next_block-async-friendl.patch text/x-patch 23.9 KB
v22b-0005-review.patch text/x-patch 1.8 KB
v22b-0006-Add-common-interface-for-TBMIterators.patch text/x-patch 17.2 KB
v22b-0007-review.patch text/x-patch 1.3 KB
v22b-0008-BitmapHeapScan-initialize-some-prefetch-state-e.patch text/x-patch 2.4 KB
v22b-0009-BitmapHeapScan-uses-unified-iterator.patch text/x-patch 14.2 KB
v22b-0010-review.patch text/x-patch 2.0 KB
v22b-0011-BitmapHeapScan-Make-prefetch-sync-error-more-de.patch text/x-patch 1.1 KB
v22b-0012-Push-current-scan-descriptor-into-specialized-s.patch text/x-patch 15.0 KB
v22b-0013-review.patch text/x-patch 1.7 KB
v22b-0014-Remove-ss_current-prefix-from-ss_currentScanDes.patch text/x-patch 12.6 KB
v22b-0015-Add-scan_in_progress-to-BitmapHeapScanState.patch text/x-patch 2.6 KB
v22b-0016-Make-new-bitmap-table-scan-and-bitmap-heap-scan.patch text/x-patch 20.6 KB
v22b-0017-review.patch text/x-patch 909 bytes
v22b-0018-Update-variable-names-in-bitmap-scan-descriptor.patch text/x-patch 16.5 KB
v22b-0019-review.patch text/x-patch 823 bytes
v22b-0020-BitmapHeapScan-lift-and-shift-prefetch-function.patch text/x-patch 15.9 KB
v22b-0021-BitmapHeapScan-Push-prefetch-code-into-heap-AM.patch text/x-patch 36.1 KB
v22b-0022-review.patch text/x-patch 1.2 KB
v22b-0023-BitmapHeapScan-move-per-scan-setup-into-a-helpe.patch text/x-patch 10.0 KB
v22b-0024-Remove-table-AM-callback-scan_bitmap_next_block.patch text/x-patch 13.7 KB
v22b-0025-review.patch text/x-patch 888 bytes
v22b-0026-Hard-code-TBMIterateResult-offsets-array-size.patch text/x-patch 5.2 KB
v22b-0027-review.patch text/x-patch 797 bytes
v22b-0028-Separate-TBMIterator-and-TBMIterateResult.patch text/x-patch 19.6 KB
v22b-0029-Use-streaming-I-O-in-Bitmap-Heap-Scans.patch text/x-patch 25.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2024-06-18 22:23:23 Re: assertion failure at cost_memoize_rescan()
Previous Message Andres Freund 2024-06-18 21:33:31 Re: allow changing autovacuum_max_workers without restarting