A weird bit in pg_upgrade/exec.c

From: a(dot)akenteva(at)postgrespro(dot)ru
To: pgsql-hackers(at)postgresql(dot)org
Subject: A weird bit in pg_upgrade/exec.c
Date: 2017-11-09 15:07:35
Message-ID: f9266a85d918a3cf3a386b5148aee666@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello!
I've came across a weird bit in pg_upgrade/exec.c

We have a function check_bin_dir() which goes like this (old_cluster and
new_cluster are global variables):
void check_bin_dir(ClusterInfo *cluster)
{
...
get_bin_version(&old_cluster);
get_bin_version(&new_cluster);
...
}

This function has two calls:
check_bin_dir(&old_cluster);
check_bin_dir(&new_cluster);

I'd like to substitute these last two lines with this:
get_bin_version(cluster);

Doing it would simplify the patch I'm writing, but I'm worried I might
break something that's been there for a long time and has been working
fine. Is there maybe a reason for it to be this way that I don't happen
to understand?
Also, there's the exact same situation with the get_bin_version()
function in the same file.

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2017-11-09 15:28:24 Re: Moving relation extension locks out of heavyweight lock manager
Previous Message Etsuro Fujita 2017-11-09 12:42:40 Reorder header files in alphabetical order