Re: Unicode normalization test broken output

On 2019-12-09 23:22, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> There appear to be several off-by-more-than-one errors in norm_test.c
>> print_wchar_str(). Attached is a patch to fix this (and make the output
>> a bit prettier). Result afterwards:
>
> I concur that this looks broken and your patch improves it.
> But I'm not very happy about the remaining assumption that
> we don't have to worry about characters above U+FFFF. I'd
> rather see it allocate 11 bytes per allowed pg_wchar, and
> manage the string contents with something like
>
> p += sprintf(p, "U+%04X ", *s);

Good point. Fixed in attached patch.

--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services