| From: | "Hou, Zhijie" <houzj(dot)fnst(at)cn(dot)fujitsu(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | RE: The return value of SPI_connect |
| Date: | 2020-09-29 00:18:21 |
| Message-ID: | f8d9302593874cb3b5bd31005735715d@G08CNEXMBPEKD05.g08.fujitsu.local |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> > May be we can make "int SPI_connect()" => "void SPI_connect()" and fix
> the doc ?
>
> I don't see a lot of value in changing SPI_connect() in isolation.
> It's part of an API suite that generally expects functions to return error
> codes.
>
> There was a previous thread [1] about getting rid of useless SPI error codes
> across the board, in favor of having those functions throw errors for error
> cases. AFAICT nobody has reviewed the proposed patch there, but maybe you'd
> like to?
>
> regards, tom lane
>
> [1]
> https://www.postgresql.org/message-id/flat/cc57ea5c-592a-6c27-aca6-7ad
> 2a166c379%40gmail.com
>
Thanks ! I will look into it.
Best regards,
houzj
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-09-29 00:37:52 | Re: Small improvements to pg_list.h's linitial(), lsecond(), lthird() etc macros |
| Previous Message | Andy Fan | 2020-09-29 00:08:17 | Re: BLOB / CLOB support in PostgreSQL |