pg_upgrade test writes to source directory

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: pg_upgrade test writes to source directory
Date: 2022-05-25 06:21:26
Message-ID: f80ace33-11fb-1cd3-20f8-98f51d151088@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

The 002_pg_upgrade.pl test leaves a file delete_old_cluster.sh in the
source directory. In vpath builds, there shouldn't be any files written
to the source directory.

Note that the TAP tests run with the source directory as the current
directory, so this is the result of pg_upgrade leaving its output files
in the current directory.

It looks like an addition of

chdir $ENV{TESTOUTDIR};

could fix it. Please check the patch.

Attachment Content-Type Size
0001-Run-pg_upgrade-test-in-build-directory.patch text/plain 2.0 KB

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Amit Kapila 2022-05-25 06:43:17 Re: Multi-Master Logical Replication
Previous Message Andres Freund 2022-05-25 06:17:39 Re: Assert name/short_desc to prevent SHOW ALL segfault