| From: | Tatsuro Yamada <tatsuro(dot)yamada(dot)tf(at)nttcom(dot)co(dot)jp> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, torikoshia <torikoshia(at)oss(dot)nttdata(dot)com> |
| Cc: | legrand legrand <legrand_legrand(at)hotmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Is it useful to record whether plans are generic or custom? |
| Date: | 2021-01-27 22:53:18 |
| Message-ID: | f8010f7d-0176-8564-ae9b-92088ced3ae0@nttcom.co.jp_1 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020/12/04 14:29, Fujii Masao wrote:
>
> On 2020/11/30 15:24, Tatsuro Yamada wrote:
>> Hi Torikoshi-san,
>>
>>
>>> In this patch, exposing new columns is mandatory, but I think
>>> it's better to make it optional by adding a GUC something
>>> like 'pgss.track_general_custom_plans.
>>>
>>> I also feel it makes the number of columns too many.
>>> Just adding the total time may be sufficient.
>>
>>
>> I think this feature is useful for DBA. So I hope that it gets
>> committed to PG14. IMHO, many columns are Okay because DBA can
>> select specific columns by their query.
>> Therefore, it would be better to go with the current design.
>
> But that design may waste lots of memory. No? For example, when
> plan_cache_mode=force_custom_plan, the memory used for the columns
> for generic plans is not used.
>
> Regards,
Sorry for the super delayed replay.
I don't think that because I suppose that DBA uses plan_cache_mode if
they faced an inefficient execution plan. And the parameter will be used
as a session-level GUC parameter, not a database-level.
Regards,
Tatsuro Yamada
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tatsuro Yamada | 2021-01-27 22:56:22 | Re: Is it useful to record whether plans are generic or custom? |
| Previous Message | Marcelo Zabani | 2021-01-27 22:01:43 | Index predicate locking and serializability contention |