Re: bad logging around broken restore_command

From: David Steele <david(at)pgmasters(dot)net>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: bad logging around broken restore_command
Date: 2020-03-09 12:47:18
Message-ID: f7abecee-c532-4b29-2bd9-d32758a8f970@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Jeff,

On 2/6/20 9:23 AM, Fujii Masao wrote:
>
>> I've attached a patch which emits a LOG message for ENOENT.
>
> Isn't it better to use "could not stat file" message even in ENOENT case?
> If yes, something like message that you used in the patch should be
> logged as DETAIL or HINT message. So, what about the attached patch?

What do you think of Fujii's changes?

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2020-03-09 13:00:34 Re: POC: rational number type (fractions)
Previous Message Bert Scalzo 2020-03-09 12:46:49 New feature request: Query Rewrite Cache