Re: [POC] Fast COPY FROM command for the table with foreign partitions

From: Alexey Kondratov <a(dot)kondratov(at)postgrespro(dot)ru>
To: Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru>
Cc: Amit Langote <amitlangote09(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(at)2ndquadrant(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, Etsuro Fujita <etsuro(dot)fujita(at)gmail(dot)com>, PostgreSQL-Dev <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [POC] Fast COPY FROM command for the table with foreign partitions
Date: 2020-07-28 07:54:22
Message-ID: f78bd4d6d84fafcc690c0088aabe1360@postgrespro.ru
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2020-07-28 03:33, Andrey Lepikhov wrote:
> 27.07.2020 21:34, Alexey Kondratov пишет:
>> Hi Andrey,
>>
>> On 2020-07-23 09:23, Andrey V. Lepikhov wrote:
>>> On 7/16/20 2:14 PM, Amit Langote wrote:
>>>> Amit Langote
>>>> EnterpriseDB: http://www.enterprisedb.com
>>>>
>>>
>>> Version 5 of the patch. With changes caused by Amit's comments.
>>
>> Just got a segfault with your v5 patch by deleting from a foreign
>> table. It seems that ShutdownForeignScan inside node->fdwroutine
>> doesn't have a correct pointer to the required function.
>>
>> I haven't had a chance to look closer on the code, but you can easily
>> reproduce this error with the attached script (patched Postgres
>> binaries should be available in the PATH). It works well with master
>> and fails with your patch applied.
>
> I used master a3ab7a707d and v5 version of the patch with your script.
> No errors found. Can you check your test case?

Yes, my bad. I forgot to re-install postgres_fdw extension, only did it
for postgres core, sorry for disturb.

Regards
--
Alexey Kondratov

Postgres Professional https://www.postgrespro.com
Russian Postgres Company

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2020-07-28 07:59:48 Re: printing oid with %d
Previous Message vignesh C 2020-07-28 05:35:05 Re: Parallel worker hangs while handling errors.