| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Extracting cross-version-upgrade knowledge from buildfarm client |
| Date: | 2023-01-16 19:08:38 |
| Message-ID: | f76e0ece-9190-5d99-9ed2-e9f624bad546@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2023-01-15 Su 18:37, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Those replacement lines are very difficult to read. I think use of
>> extended regexes and some multi-part replacements would help. I'll have
>> a go at that tomorrow.
> Yeah, after I wrote that code I remembered about \Q ... \E, which would
> eliminate the need for most of the backslashes and probably make things
> better that way. I didn't get around to improving it yet though, so
> feel free to have a go.
>
>
OK, here's my version. It tests clean against all of crake's dump files
back to 9.2.
To some extent it's a matter of taste, but I hate very long regex lines
- it makes it very hard to see what's actually changing, so I broke up
most of those.
Given that we are looking at newlines in some places I decided that
after all it was important to convert CRLF to LF.
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
| Attachment | Content-Type | Size |
|---|---|---|
| adjustupgrade-3.patch | text/x-patch | 16.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2023-01-16 19:29:56 | almost-super-user problems that we haven't fixed yet |
| Previous Message | Torsten Förtsch | 2023-01-16 18:59:33 | minor bug |