| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Fix volatile vs. pointer confusion |
| Date: | 2019-03-11 07:23:39 |
| Message-ID: | f747368d-9e1a-c46a-ac76-3c27da32e8e4@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Variables used after a longjmp() need to be declared volatile. In
case of a pointer, it's the pointer itself that needs to be declared
volatile, not the pointed-to value. So we need
PyObject *volatile items;
instead of
volatile PyObject *items; /* wrong */
Attached patch fixes a couple of cases of that. Most instances were
already correct.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Fix-volatile-vs.-pointer-confusion.patch | text/plain | 2.7 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andy Fan | 2019-03-11 07:59:26 | I have some troubles to run test_shm_mq; |
| Previous Message | Michael Paquier | 2019-03-11 07:21:14 | Re: BUG #15668: Server crash in transformPartitionRangeBounds |