From: | Yury Zhuravlev <u(dot)zhuravlev(at)postgrespro(dot)ru> |
---|---|
To: | <pgsql-general(at)postgresql(dot)org> |
Subject: | Re: Building PostgreSQL 9.6devel sources with Microsoft Visual C++ 2015? |
Date: | 2016-01-21 22:16:28 |
Message-ID: | f6e9bfd7-0a1d-4152-9b00-dffde1807fb2@postgrespro.ru |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-general |
Tom Lane wrote:
> Ick. Even if that works today, it seems absolutely guaranteed to fail
> in future, as soon as Microsoft either puts back the visible declaration
> or changes the struct contents. If they've made a conscious decision
> to not export the struct anymore, it's likely because they intend to
> change it ... so I'd put the half-life of this "fix" at no more than one
> Visual Studio release.
Yes. You right. But at the moment, it's better than nothing. In addition,
we can then do something like this:
#if _MSC_VER >= 1800 && _MSC_VER < 1820
after MS push fix.
> Hopefully, if they removed the visible declaration intentionally, they
> provided some other way to get at those locale names. That's what we
> need to be looking for, not hoping that direct access to undocumented
> structures will continue to work.
It's more like a simple bug after refactoring. But I will try find another
way. (I don't like undocumented structures)
Thanks.
--
Yury Zhuravlev
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
From | Date | Subject | |
---|---|---|---|
Next Message | Jason Dusek | 2016-01-21 22:41:32 | HeapTuple to JSON -- composite_to_json()? |
Previous Message | Andrew Sullivan | 2016-01-21 22:16:10 | Re: Auotmated postgres failover |