Re: pgsql: Extended statistics on expressions

From: Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>
To: David Rowley <dgrowleyml(at)gmail(dot)com>
Cc: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Extended statistics on expressions
Date: 2021-04-06 14:59:38
Message-ID: f6c98599-70dc-2c55-3dba-b7360e91a666@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 4/1/21 4:24 AM, David Rowley wrote:
> On Thu, 1 Apr 2021 at 14:49, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> wrote:
>> I think that's probably sufficient for now. More testing may be useful
>> once I refactor the code a bit to make it more readable.
>
> Just to let you know, I left it running a bit longer. About 70 mins
> now. No crashes yet.
>

I've pushed a fix for this. I've reworked the loop where we apply the
selected extended statistics, breaking the complex "if" condition into
smaller / easier to understand pieces.

regards

--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2021-04-06 15:19:09 pgsql: psql: Show all query results by default
Previous Message Tomas Vondra 2021-04-06 14:56:46 pgsql: Fix handling of clauses incompatible with extended statistics