| From: | Andrei Zubkov <zubkov(at)moonset(dot)ru> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: [PATCH] pg_statio_all_tables: several rows per table due to invalid TOAST index |
| Date: | 2021-11-30 08:57:25 |
| Message-ID: | f63c476208b74f980b8ede898c7178b455f5d593.camel@moonset.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi, Michael
Thank you for your attention!
On Tue, 2021-11-30 at 17:29 +0900, Michael Paquier wrote:
> Hmm. Why should we care about invalid indexes at all, including
> pg_statio_all_indexes?
>
I think we should care about them at least because they are exists and
can consume resources. For example, invalid index is to be updated by
DML operations.
Of course we can exclude such indexes from a view using isvalid,
isready, islive fields. But in such case we should mention this in the
docs, and more important is that the new such states of indexes can
appear in the future causing change in a view definition. Counting all
indexes regardless of states seems more reasonable to me.
--
Andrei Zubkov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2021-11-30 09:28:01 | Re: Skipping logical replication transactions on subscriber side |
| Previous Message | Michael Paquier | 2021-11-30 08:29:12 | Re: [PATCH] pg_statio_all_tables: several rows per table due to invalid TOAST index |