From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | Christoph Berg <myon(at)debian(dot)org>, Noah Misch <noah(at)leadboat(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, pgsql-hackers(at)postgresql(dot)org |
Subject: | Re: [HACKERS] Time to change pg_regress diffs to unified by default? |
Date: | 2019-01-03 11:02:47 |
Message-ID: | f619ac7d-9c56-7280-a094-fe204f7b58d7@2ndquadrant.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 02/01/2019 21:44, Tom Lane wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
>> While we're considering the pg_regress output, what do you think about
>> replacing the ======... separator with a standard diff separator like
>> "diff %s %s %s\n". This would make the file behave more like a proper
>> diff file, for use with other tools. And it shows the diff options
>> used, for clarity. See attached patch.
>
> I'm confused by this patch. Doesn't moving the diff call like that
> break the logic completely?
For clarification, I have attached a "before" and "after".
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Attachment | Content-Type | Size |
---|---|---|
regression.diffs.new | text/plain | 920 bytes |
regression.diffs.old | text/plain | 748 bytes |
From | Date | Subject | |
---|---|---|---|
Next Message | Nikolay Shaplov | 2019-01-03 11:15:11 | Re: [PATCH] check for ctags utility in make_ctags |
Previous Message | Daniel Gustafsson | 2019-01-03 10:20:29 | Re: [HACKERS] Time to change pg_regress diffs to unified by default? |