Re: [DOCS] alter_foreign_table.sgml typo

From: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
To: Mehmet Emin KARAKAŞ <emin100(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [DOCS] alter_foreign_table.sgml typo
Date: 2023-06-07 15:53:56
Message-ID: f555abae-8f11-e0a8-0f51-93dfd56d345e@oss.nttdata.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2023/06/07 23:25, Mehmet Emin KARAKAŞ wrote:
> Fixed typo in SQL.
>
> Current: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3 'value3');
>
> Fixed: ALTER FOREIGN TABLE myschema.distributors OPTIONS (ADD opt1 'value', SET opt2 'value2', DROP opt3);
>
> Drop options do not get a value.

Thanks for the report! I agree with your findings and the patch looks good to me.
I will commit the patch barring any objection.

Regards,

--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Yura Sokolov 2023-06-07 16:05:54 Re: Let's make PostgreSQL multi-threaded
Previous Message Isaac Morland 2023-06-07 15:48:32 Disk space not released after schema deletion