Re: [COMMITTERS] pgsql: Clean up Perl code according to perlcritic

On 03/28/2017 07:31 AM, Dagfinn Ilmari Mannsåker wrote:
> Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> writes:
>
>> I would try something like this:
>>
>> @opts = grep { $_ !~ /\$\(/ && $_ =~ /^--/ }
>> map { s/\Q$(top_builddir)\E/\"$topdir\"/; }
>> split(/\s+/, $1);
> That map is not going to work: it'll modify the values returned by
> split(), but s/// (without the /r modifier, which was added in 5.14)
> returns the number of substitutions made, not the modified string.

Oh. Bleah.

OK. well, we should note that in comments then.

cheers

andrew

--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services