Re: Regression tests fail with PG12

From: "Inoue, Hiroshi" <h-inoue(at)dream(dot)email(dot)ne(dot)jp>
To: Christoph Berg <myon(at)debian(dot)org>
Cc: PostgreSQL ODBC <pgsql-odbc(at)postgresql(dot)org>
Subject: Re: Regression tests fail with PG12
Date: 2019-11-12 04:45:51
Message-ID: f4566e2f-e387-b9fa-c55c-0501c18144ef@dream.email.ne.jp
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-odbc

Hi Christoph,

Sorry for the late reply.
Could you try the attached patch?

regards,
Hiroshi Inoue

On 2019/11/08 10:48, Inoue, Hiroshi wrote:
> Hi Christoph,
>
> I would take care of this issue.
>
> Thansks.
> Hiroshi Inoue
>
> On 2019/11/07 17:51, Christoph Berg wrote:
>> Hi,
>>
>> the psqlodbc regression tests need updating for PG12's new floating
>> point output format. Also, "abstime" got removed as type.
>>
>> *** ./expected/result-conversions.out    Fri Oct 11 15:03:22 2019
>> --- results/result-conversions.out    Thu Nov  7 09:47:19 2019
>> ***************
>> *** 638,645 ****
>>    '1.234' (float4) as SQL_C_INTERVAL_HOUR_TO_MINUTE: interval sign:
>> 0 unknown interval type: 0
>>    '1.234' (float4) as SQL_C_INTERVAL_HOUR_TO_SECOND: interval sign:
>> 0 unknown interval type: 0
>>    '1.234' (float4) as SQL_C_INTERVAL_MINUTE_TO_SECOND: interval
>> sign: 0 unknown interval type: 0
>> ! '1.23456789012' (float8) as SQL_C_CHAR: 1.2345678901199999
>> ! '1.23456789012' (float8) as SQL_C_WCHAR: 1.2345678901199999
>>    '1.23456789012' (float8) as SQL_C_SSHORT: 1
>>    '1.23456789012' (float8) as SQL_C_USHORT: 1
>>    '1.23456789012' (float8) as SQL_C_SLONG: 1
>> --- 638,645 ----
>>    '1.234' (float4) as SQL_C_INTERVAL_HOUR_TO_MINUTE: interval sign:
>> 0 unknown interval type: 0
>>    '1.234' (float4) as SQL_C_INTERVAL_HOUR_TO_SECOND: interval sign:
>> 0 unknown interval type: 0
>>    '1.234' (float4) as SQL_C_INTERVAL_MINUTE_TO_SECOND: interval
>> sign: 0 unknown interval type: 0
>> ! '1.23456789012' (float8) as SQL_C_CHAR: 1.23456789012
>> ! '1.23456789012' (float8) as SQL_C_WCHAR: 1.23456789012
>>    '1.23456789012' (float8) as SQL_C_SSHORT: 1
>>    '1.23456789012' (float8) as SQL_C_USHORT: 1
>>    '1.23456789012' (float8) as SQL_C_SLONG: 1
>> ***************
>> *** 657,663 ****
>>    '1.23456789012' (float8) as SQL_C_VARBOOKMARK: SQLGetData failed
>>    07006=Received an unsupported type from Postgres.
>>    '1.23456789012' (float8) as SQL_C_TYPE_TIME: h: 0 m: 0 s: 0
>> ! '1.23456789012' (float8) as SQL_C_NUMERIC: precision: 17 scale: 16
>> sign: 16 val: 7fc46a5d54dc2b000000000000000000
>>    '1.23456789012' (float8) as SQL_C_GUID: SQLGetData failed
>>    07006=Received an unsupported type from Postgres.
>>    '1.23456789012' (float8) as SQL_C_INTERVAL_YEAR: interval sign: 0
>> unknown interval type: 0
>> --- 657,663 ----
>>    '1.23456789012' (float8) as SQL_C_VARBOOKMARK: SQLGetData failed
>>    07006=Received an unsupported type from Postgres.
>>    '1.23456789012' (float8) as SQL_C_TYPE_TIME: h: 0 m: 0 s: 0
>> ! '1.23456789012' (float8) as SQL_C_NUMERIC: precision: 12 scale: 11
>> sign: 11 val: 141a99be1c0000000000000000000000
>>    '1.23456789012' (float8) as SQL_C_GUID: SQLGetData failed
>>    07006=Received an unsupported type from Postgres.
>>    '1.23456789012' (float8) as SQL_C_INTERVAL_YEAR: interval sign: 0
>> unknown interval type: 0
>>
>> ....
>>
>> --- 674,679 ----
>>    '1.23456789012' (float8) as SQL_C_INTERVAL_HOUR_TO_MINUTE:
>> interval sign: 0 unknown interval type: 0
>>    '1.23456789012' (float8) as SQL_C_INTERVAL_HOUR_TO_SECOND:
>> interval sign: 0 unknown interval type: 0
>>    '1.23456789012' (float8) as SQL_C_INTERVAL_MINUTE_TO_SECOND:
>> interval sign: 0 unknown interval type: 0
>> ! '2011-01-14 16:49:18+03' (abstime) as SQL_C_CHAR: SQLExecDirect failed
>> ! 42704=ERROR: type "abstime" does not exist;
>> ! Error while executing the query
>>
>>
>> Spotted by Debian's CI pipeline.
>>
>> https://salsa.debian.org/postgresql/psqlodbc/-/jobs/402606
>>
>> Christoph

Attachment Content-Type Size
result-convesions.patch text/plain 177.1 KB

In response to

Responses

Browse pgsql-odbc by date

  From Date Subject
Next Message Andrew Kagan 2019-11-14 23:03:30 Windows ODBC Driver configuration help
Previous Message Inoue, Hiroshi 2019-11-08 01:48:14 Re: Regression tests fail with PG12