| From: | Victor Spirin <v(dot)spirin(at)postgrespro(dot)ru> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: psql tab-complete |
| Date: | 2019-10-25 08:57:18 |
| Message-ID: | f450fc57-a147-19d0-e50c-33571c52cc13@postgrespro.ru |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
This patch resolved one problem in the tab-complete.c on MSVC. The
VA_ARGS_NARGS macros now work correctly on Windows.
Victor Spirin
Postgres Professional:http://www.postgrespro.com
The Russian Postgres Company
25.10.2019 0:53, Victor Spirin пишет:
> Yes, I found, that VA_ARGS_NARGS(__ VA_ARGS__) macros always return 1
> on Windows.
>
> Victor Spirin
> Postgres Professional:http://www.postgrespro.com
> The Russian Postgres Company
>
> 25.10.2019 0:48, Tom Lane пишет:
>> Victor Spirin <v(dot)spirin(at)postgrespro(dot)ru> writes:
>>> I found some problem with tab-complete in the 12 version. I checked
>>> this in the Windows.
>> This change seems to break the case intended by the comment,
>> ie given the context
>>
>> SELECT * FROM tablename WHERE <tab>
>>
>> we want to offer the columns of "tablename" as completions.
>>
>> I'd be the first to agree that that's completely lame, as there
>> are any number of related cases it fails to cover ... but this
>> patch isn't making it better.
>>
>> regards, tom lane
>>
>>
>
>
| Attachment | Content-Type | Size |
|---|---|---|
| nargs.patch | text/plain | 1.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2019-10-25 09:48:37 | define bool in pgtypeslib_extern.h |
| Previous Message | Amit Langote | 2019-10-25 07:42:24 | Re: [PATCH] Do not use StdRdOptions in Access Methods |