| From: | Vik Fearing <vik(dot)fearing(at)2ndquadrant(dot)com> |
|---|---|
| To: | Surafel Temesgen <surafel3000(at)gmail(dot)com> |
| Cc: | PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: WIP: System Versioned Temporal Table |
| Date: | 2020-01-03 13:22:34 |
| Message-ID: | f3fb6bae-84b2-735a-20c8-b9918e62aaf3@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/01/2020 11:57, Surafel Temesgen wrote:
>
>
> On Thu, Jan 2, 2020 at 12:12 AM Vik Fearing
> <vik(dot)fearing(at)2ndquadrant(dot)com <mailto:vik(dot)fearing(at)2ndquadrant(dot)com>> wrote:
>
> This does not compile against current head (0ce38730ac).
>
>
> gram.y: error: shift/reduce conflicts: 6 found, 0 expected
>
>
> Rebased and conflict resolved i hope it build clean this time
>
It does but you haven't included your tests file so `make check` fails.
It seems clear to me that you haven't tested it at all anyway. The
temporal conditions do not return the correct results, and the syntax is
wrong, too. Also, none of my previous comments have been addressed
except for "system versioning" instead of "system_versioning". Why?
--
Vik Fearing
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Kapila | 2020-01-03 13:33:27 | Re: sidewinder has one failure |
| Previous Message | Mikael Kjellström | 2020-01-03 13:04:10 | Re: sidewinder has one failure |