From: | Amit Langote <Langote_Amit_f8(at)lab(dot)ntt(dot)co(dot)jp> |
---|---|
To: | Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | warning in twophase.c |
Date: | 2017-04-25 01:06:30 |
Message-ID: | f20ac2ed-65a9-6511-e100-8fa369184603@lab.ntt.co.jp |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Been seeing this warning recently:
twophase.c: In function ‘RecoverPreparedTransactions’:
twophase.c:1916:9: warning: variable ‘overwriteOK’ set but not used
[-Wunused-but-set-variable]
bool overwriteOK = false;
^~~~~~~~~~~
As the message says, the value of overwriteOK is not used anywhere in
RecoverPreparedTransactions:
bool overwriteOK = false;
/*
* It's possible that SubTransSetParent has been set before, if
* the prepared transaction generated xid assignment records. Test
* here must match one used in AssignTransactionId().
*/
if (InHotStandby && (hdr->nsubxacts >= PGPROC_MAX_CACHED_SUBXIDS ||
XLogLogicalInfoActive()))
overwriteOK = true;
Couldn't we get rid of it?
Thanks,
Amit
From | Date | Subject | |
---|---|---|---|
Next Message | Noah Misch | 2017-04-25 01:10:52 | Re: PG_GETARG_GISTENTRY? |
Previous Message | Amit Langote | 2017-04-25 00:29:50 | Re: Adding support for Default partition in partitioning |