Fix for 2 test cases of JDBC test suite

From: Rene Pijlman <rene(at)lab(dot)applinet(dot)nl>
To: pgsql-patches(at)postgresql(dot)org
Cc: pgsql-jdbc(at)postgresql(dot)org
Subject: Fix for 2 test cases of JDBC test suite
Date: 2001-09-06 21:45:14
Message-ID: f1rfpt877sdpsjogfrtgnk4vage3cprg50@4ax.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-jdbc pgsql-patches

Attached is a patch that fixes 2 test cases of the JDBC test
suite. This reduces the number of failures from 9 to 7.

Both ConnectionTest and JBuilderTest did not create their own
tables, which caused these test cases to fail with "relation ...
does not exist". It appears these test cases relied on tables
created by the example code elsewhere in the source tree. I've
added the necessary "create table" and "drop table" statements
to the test cases, using the column definitions from the example
code.

While working on that I modified the helper method createTable
in JDBC2Tests.java to take a table parameter, rather than using
table names passed via the properties in build.xml. I'm not sure
what that was good for, and in fact, except for the default
table name "jdbctest", this functionality wasn't used at all.

Regards,
René Pijlman <rene(at)lab(dot)applinet(dot)nl>

Attachment Content-Type Size
patch.diff text/plain 5.5 KB

Responses

Browse pgsql-jdbc by date

  From Date Subject
Next Message Rene Pijlman 2001-09-06 22:11:25 Re: Why JDBC 1?
Previous Message Tom Falconer 2001-09-06 21:30:58 DatabaseMetadata problems

Browse pgsql-patches by date

  From Date Subject
Next Message Dave Cramer 2001-09-07 00:01:51 Re: JDBC patch procedures (Re: [PATCHES] Patch for jdbc2 ResultSet.java)
Previous Message Vadim Kogan 2001-09-06 21:18:11 Re: IPv6 Support for INET/CIDR types.