| From: | Andrew Dunstan <andrew(dot)dunstan(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Jacob Champion <pchampion(at)pivotal(dot)io> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that |
| Date: | 2018-08-06 19:16:56 |
| Message-ID: | f10a85c0-118a-0d59-e052-7826f4f00c38@2ndQuadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 08/06/2018 03:13 PM, Tom Lane wrote:
> Jacob Champion <pchampion(at)pivotal(dot)io> writes:
>> We recently ran into an issue in pg_dump that caused the initial
>> sort-by-name pass to return incorrect results. It doesn't seem to
>> affect overall correctness, since the later toposort pass takes care
>> of dependencies, but it does occasionally cause a spurious diff in
>> dump output before and after a pg_upgrade run.
> Do you mean "incorrect results", or just "unstable results"?
> If the former, what's incorrect about it?
>
>
I'd also like to see a test case.
We should perhaps have a more representative set of data for the upgrade
testing, both same version and cross-version, which judge success by
comparing pre and post dumps, but I don't recall ever seeing this.
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jacob Champion | 2018-08-06 19:23:59 | Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that |
| Previous Message | Tom Lane | 2018-08-06 19:13:06 | Re: pg_dump: sortDumpableObjectsByTypeName() doesn't always do that |