From: | "Daniel Verite" <daniel(at)manitou-mail(dot)org> |
---|---|
To: | "Andres Freund" <andres(at)anarazel(dot)de> |
Cc: | "Michael Paquier" <michael(at)paquier(dot)xyz>,"Justin Pryzby" <pryzby(at)telsasoft(dot)com>,pgsql-hackers(at)lists(dot)postgresql(dot)org |
Subject: | Re: Cleanup/remove/update references to OID column |
Date: | 2019-04-15 16:35:12 |
Message-ID: | f06e9735-3717-4904-8c95-47d0b9c3bb10@manitou-mail.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Andres Freund wrote:
> Yes, I was planning to commit that soon-ish. There still seemed
> review / newer versions happening, though, so I was thinking of waiting
> for a bit longer.
You might want to apply this trivial one in the same batch:
index 452f307..7cfb67f 100644
--- a/src/bin/pg_dump/pg_dump.c
+++ b/src/bin/pg_dump/pg_dump.c
@@ -428,7 +428,7 @@ main(int argc, char **argv)
InitDumpOptions(&dopt);
- while ((c = getopt_long(argc, argv,
"abBcCd:E:f:F:h:j:n:N:oOp:RsS:t:T:U:vwWxZ:",
+ while ((c = getopt_long(argc, argv,
"abBcCd:E:f:F:h:j:n:N:Op:RsS:t:T:U:vwWxZ:",
long_options,
&optindex)) != -1)
{
switch (c)
"o" in the options list is a leftover. Leaving it in getopt_long() has the
effect that pg_dump -o fails (per the default case in the switch),
but it's missing the expected error message (pg_dump: invalid option -- 'o')
Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2019-04-15 16:48:57 | Re: block-level incremental backup |
Previous Message | Ashwin Agrawal | 2019-04-15 16:29:37 | Re: Zedstore - compressed in-core columnar storage |