| From: | Andrey Lepikhov <a(dot)lepikhov(at)postgrespro(dot)ru> |
|---|---|
| To: | Richard Guo <guofenglinux(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-bugs(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Clause accidentally pushed down ( Possible bug in Making Vars outer-join aware) |
| Date: | 2023-02-27 06:23:57 |
| Message-ID: | efb33bee-145d-95a8-1048-2e7b8f282e2c@postgrespro.ru |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs |
On 23/2/2023 11:36, Richard Guo wrote:
> I've realized this hack is not correct :-(. References to A Vars and B
> Vars in higher qual levels do not need this adjustment. So this code
> change would add unnecessary relids for clauses that involve A Vars or B
> Vars but not C Vars, resulting them being placed at higher place than
> needed.
>
> Maybe what we need is to add in commute_below_l (assuming it has been
> recorded in SpecialJoinInfo) rather than commute_below of outer joins
> mentioned within the clause?
Doing a comparison of pg15 and master initsplan.c I found that a clear
and documented algorithm for delaying the application of a qual is lost
or replaced with some commute_* fields.
It is not clear how we guarantee correct application delay of a qual.
Which part of the code implements it now?
--
regards,
Andrey Lepikhov
Postgres Professional
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Richard Guo | 2023-02-27 07:36:06 | Re: Clause accidentally pushed down ( Possible bug in Making Vars outer-join aware) |
| Previous Message | Michael Paquier | 2023-02-27 04:01:21 | Re: BUG #17744: Fail Assert while recoverying from pg_basebackup |