Re: XMLDocument (SQL/XML X030)

From: Jim Jones <jim(dot)jones(at)uni-muenster(dot)de>
To: Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>
Cc: Chapman Flack <jcflack(at)acm(dot)org>, Robert Treat <rob(at)xzilla(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: XMLDocument (SQL/XML X030)
Date: 2025-01-23 15:06:12
Message-ID: ef55cfad-7e16-45f8-81f3-5caec1754452@uni-muenster.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi

On 23.01.25 07:50, Pavel Stehule wrote:
> I think so in this form (just forward input to output) I have no
> objection. 
>
> There is a benefit with a) possible zero work with migration from db2,
> b) nobody needs to repeat a work which is a correct implementation of
> XMLDOCUMENT function.
>
> Maybe opened question can be implementation like classic scalar
> function or via XmlExpr
>
> In this moment I prefer to use XmlExpr from consistency reasons

To keep it consistent with the existing code, I think this function is
in the right place. There are similar functions in xml.c, e.g.
xmltotext, texttoxml.

I updated the function comment and commit message (v4 attached) to make
things clearer.

Since the status of this patch is waiting on author, is there anything
else I should take a look / improve?

Thanks!

Best regards,Jim

Attachment Content-Type Size
v4-0001-Add-XMLDocument-function-SQL-XML-X030.patch text/x-patch 10.7 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Japin Li 2025-01-23 15:13:39 Re: Compression of bigger WAL records
Previous Message Álvaro Herrera 2025-01-23 15:04:32 Re: Allow NOT VALID foreign key constraints on partitioned tables.