Re: run pgindent on a regular basis / scripted manner

On 2023-02-06 Mo 09:40, Robert Haas wrote:
> On Sat, Feb 4, 2023 at 12:37 PM Tom Lane<tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>> But it's not clear to me why you're allergic to the perl wrapper?
>> It's not like that's the only perl infrastructure in our build process.
>> Also, whether or not we could push some of what it does into pg_bsd_indent
>> proper, I can't see pushing all of it (for instance, the very PG-specific
>> list of typedef exclusions).
> I don't mind that there is a script. I do mind that it's not that good
> of a script. There have been some improvements for which I am
> grateful, like removing the thing where the first argument was taken
> as a typedefs file under some circumstances. But there are still some
> things that I would like:
>
> 1. I'd like to be able to run pgindent src/include and have it indent
> everything relevant under src/include. Right now that silently does
> nothing.
>
> 2. I'd like an easy way to indent the unstaged files in the current
> directory (e.g. pgindent --dirty) or the files that have been queued
> up for commit (e.g. pgindent --cached).
>
> 3. I'd also like an easy way to indent every file touched by a recent
> commit, e.g. pgindent --commit HEAD, pgindent --commit HEAD~2,
> pgindent --commit 62e1e28bf7.

Good suggestions. 1 and 3 seem fairly straightforward. I'll start on
those, and look into 2.

cheers

andrew

--
Andrew Dunstan
EDB:https://www.enterprisedb.com