| From: | Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com> |
|---|---|
| To: | Christoph Berg <myon(at)debian(dot)org> |
| Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Daniel Gustafsson <daniel(at)yesql(dot)se>, Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) |
| Date: | 2023-03-14 14:24:41 |
| Message-ID: | ef0cbd4e-0e52-e634-da52-1609e27e939e@enterprisedb.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 3/14/23 11:34, Christoph Berg wrote:
> Re: Tomas Vondra
>> and I don't think there's a good place to inject the 'rm' so I ended up
>> adding a 'cleanup_cmd' right after 'compress_cmd'. But it seems a bit
>> strange / hacky. Maybe there's a better way?
>
> Does the file need to be removed at all? Could we leave it there and
> have "make clean" remove it?
>
I don't think that'd work, because of the automatic "discovery" where we
check if a file exists, and if not we try to append .gz and .lz4. So if
you leave the .toc, we'd not find the .lz4, making the test useless ...
regards
--
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2023-03-14 15:10:52 | pgsql: Remove unnecessary code in dependency_is_compatible_expression() |
| Previous Message | Daniel Gustafsson | 2023-03-14 13:43:48 | pgsql: doc: spell out full productname |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2023-03-14 14:34:16 | Re: Progress report of CREATE INDEX for nested partitioned tables |
| Previous Message | Nazir Bilal Yavuz | 2023-03-14 14:07:15 | Re: meson: Non-feature feature options |